Unverified Commit 45d4daf0 authored by Sören Wegener's avatar Sören Wegener Committed by Soeren Wegener
Browse files

Check for falsy existingUser variable. Fixes #1369



Use another return code for "User already exist"
This allows external scripts differentiating between "failure" and "everything is fine"
Co-Authored-By: default avatarMax Wu <jackymaxj@gmail.com>
Signed-off-by: default avatarSoeren Wegener <wegener92@gmail.com>
parent f0c26b3a
......@@ -37,9 +37,9 @@ function getPass (argv, action) {
async function createUser (argv) {
const existingUser = await models.User.findOne({ where: { email: argv['add'] } })
// Cannot create already-existing users
if (existingUser !== undefined) {
if (existingUser) {
console.log(`User with e-mail ${existingUser.email} already exists! Aborting ...`)
process.exit(1)
process.exit(2)
}
const pass = getPass(argv, 'add')
......@@ -56,7 +56,7 @@ async function createUser (argv) {
async function deleteUser (argv) {
// Cannot delete non-existing users
const existingUser = await models.User.findOne({ where: { email: argv['del'] } })
if (existingUser === undefined) {
if (!existingUser) {
console.log(`User with e-mail ${argv['del']} does not exist, cannot delete`)
process.exit(1)
}
......@@ -71,7 +71,7 @@ async function deleteUser (argv) {
async function resetUser (argv) {
const existingUser = await models.User.findOne({ where: { email: argv['reset'] } })
// Cannot reset non-existing users
if (existingUser === undefined) {
if (!existingUser) {
console.log(`User with e-mail ${argv['reset']} does not exist, cannot reset`)
process.exit(1)
}
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment